SimpleMemoryCheck.cc

Go to the documentation of this file.

// -*- C++ -*-
//
// Package:     Services
// Class  :     Memory
//
// Implementation:
//
// Original Author:  Jim Kowalkowski
//
// Change Log
//
// 1 - Apr 25, 2008 M. Fischler
//        Collect event summary information and output to XML file and logger
//        at the end of the job.  Involves split-up of updateAndPrint method.
//
// 2 - May 7, 2008 M. Fischler
//      Collect module summary information and output to XML file and logger
//        at the end of the job.
//
// 3 - Jan 14, 2009 Natalia Garcia Nebot
//        Added:        - Average rate of growth in RSS and peak value attained.
//                - Average rate of growth in VSize over time, Peak VSize
//
//
#include "FWCore/ServiceRegistry/interface/ServiceMaker.h"

#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "FWCore/ServiceRegistry/interface/ActivityRegistry.h"
#include "DataFormats/Provenance/interface/EventID.h"
#include "FWCore/Services/plugins/ProcInfoFetcher.h"

#include "DataFormats/Provenance/interface/ModuleDescription.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/MessageLogger/interface/JobReport.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
#include "FWCore/ParameterSet/interface/ParameterSetDescription.h"
#include "FWCore/ServiceRegistry/interface/Service.h"
#include "FWCore/ServiceRegistry/interface/StreamContext.h"
#include "FWCore/ServiceRegistry/interface/ModuleCallingContext.h"
#include "FWCore/Utilities/interface/Exception.h"
#include "FWCore/Utilities/interface/MallocOpts.h"
#include "FWCore/Utilities/interface/get_underlying_safe.h"

#include <cstring>
#include <iostream>
#include <memory>
#ifdef __linux__
#include <malloc.h>
#endif
#include <sstream>
//#include <stdio.h>
#include <string>
//#include <string.h>

#include <cstdio>
#include <atomic>

namespace edm {
  class EventID;
  class Timestamp;

  namespace service {
    struct smapsInfo {
      smapsInfo() : private_(), pss_() {}
      smapsInfo(double private_sz, double pss_sz) : private_(private_sz), pss_(pss_sz) {}

      bool operator==(const smapsInfo& p) const { return private_ == p.private_ && pss_ == p.pss_; }

      bool operator>(const smapsInfo& p) const { return private_ > p.private_ || pss_ > p.pss_; }

      double private_;  // in MB
      double pss_;      // in MB
    };

    class SimpleMemoryCheck {
    public:
      SimpleMemoryCheck(const ParameterSet&, ActivityRegistry&);
      ~SimpleMemoryCheck();

      static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);

      void preSourceConstruction(const ModuleDescription&);
      void postSourceConstruction(const ModuleDescription&);
      void postSourceEvent(StreamID);

      void postBeginJob();

      void postEvent(StreamContext const&);

      void postModuleBeginJob(const ModuleDescription&);
      void postModuleConstruction(const ModuleDescription&);

      void preModule(StreamContext const&, ModuleCallingContext const&);
      void postModule(StreamContext const&, ModuleCallingContext const&);

      void postEndJob();

    private:
      ProcInfo fetch();
      smapsInfo fetchSmaps();
      double pageSize() const { return pg_size_; }
      double averageGrowthRate(double current, double past, int count);
      void update();
      void updateMax();
      void andPrint(const std::string& type, const std::string& mdlabel, const std::string& mdname) const;
      void updateAndPrint(const std::string& type, const std::string& mdlabel, const std::string& mdname);
      void openFiles();

      char const* smapsLineBuffer() const { return get_underlying_safe(smapsLineBuffer_); }
      char*& smapsLineBuffer() { return get_underlying_safe(smapsLineBuffer_); }

      ProcInfo a_;
      ProcInfo b_;
      ProcInfo max_;
      edm::propagate_const<ProcInfo*> current_;
      edm::propagate_const<ProcInfo*> previous_;

      smapsInfo currentSmaps_;

      ProcInfoFetcher piFetcher_;
      double pg_size_;
      int num_to_skip_;
      //options
      bool showMallocInfo_;
      bool oncePerEventMode_;
      bool jobReportOutputOnly_;
      bool monitorPssAndPrivate_;
      std::atomic<int> count_;

      //smaps
      edm::propagate_const<FILE*> smapsFile_;
      edm::propagate_const<char*> smapsLineBuffer_;
      size_t smapsLineBufferLen_;

      //Rates of growth
      double growthRateVsize_;
      double growthRateRss_;

      // Event summary statistics               changeLog 1
      struct SignificantEvent {
        int count;
        double vsize;
        double deltaVsize;
        double rss;
        double deltaRss;
        bool monitorPssAndPrivate;
        double privateSize;
        double pss;
        edm::EventID event;
        SignificantEvent()
            : count(0),
              vsize(0),
              deltaVsize(0),
              rss(0),
              deltaRss(0),
              monitorPssAndPrivate(false),
              privateSize(0),
              pss(0),
              event() {}
        void set(double deltaV, double deltaR, edm::EventID const& e, SimpleMemoryCheck* t) {
          count = t->count_;
          vsize = t->current_->vsize;
          deltaVsize = deltaV;
          rss = t->current_->rss;
          deltaRss = deltaR;
          monitorPssAndPrivate = t->monitorPssAndPrivate_;
          if (monitorPssAndPrivate) {
            privateSize = t->currentSmaps_.private_;
            pss = t->currentSmaps_.pss_;
          }
          event = e;
        }
      };  // SignificantEvent
      friend struct SignificantEvent;
      friend std::ostream& operator<<(std::ostream& os, SimpleMemoryCheck::SignificantEvent const& se);

      /*
       Significative events for deltaVsize:
       - eventM_: Event which makes the biggest value for deltaVsize
       - eventL1_: Event which makes the second biggest value for deltaVsize
       - eventL2_: Event which makes the third biggest value for deltaVsize
       - eventR1_: Event which makes the second biggest value for deltaVsize
       - eventR2_: Event which makes the third biggest value for deltaVsize
       M>L1>L2 and M>R1>R2
       Unknown relation between Ls and Rs events ???????
       Significative events for vsize:
       - eventT1_: Event whith the biggest value for vsize
       - eventT2_: Event whith the second biggest value for vsize
       - eventT3_: Event whith the third biggest value for vsize
       T1>T2>T3
       */
      SignificantEvent eventM_;
      SignificantEvent eventL1_;
      SignificantEvent eventL2_;
      SignificantEvent eventR1_;
      SignificantEvent eventR2_;
      SignificantEvent eventT1_;
      SignificantEvent eventT2_;
      SignificantEvent eventT3_;

      /*
       Significative event for deltaRss:
       - eventRssT1_: Event whith the biggest value for rss
       - eventRssT2_: Event whith the second biggest value for rss
       - eventRssT3_: Event whith the third biggest value for rss
       T1>T2>T3
       Significative events for deltaRss:
       - eventDeltaRssT1_: Event whith the biggest value for deltaRss
       - eventDeltaRssT2_: Event whith the second biggest value for deltaRss
       - eventDeltaRssT3_: Event whith the third biggest value for deltaRss
       T1>T2>T3
       */
      SignificantEvent eventRssT1_;
      SignificantEvent eventRssT2_;
      SignificantEvent eventRssT3_;
      SignificantEvent eventDeltaRssT1_;
      SignificantEvent eventDeltaRssT2_;
      SignificantEvent eventDeltaRssT3_;

      void updateEventStats(edm::EventID const& e);
      std::string eventStatOutput(std::string title, SignificantEvent const& e) const;
      void eventStatOutput(std::string title, SignificantEvent const& e, std::map<std::string, std::string>& m) const;
      std::string mallOutput(std::string title, size_t const& n) const;

      // Module summary statistices
      struct SignificantModule {
        int postEarlyCount;
        double totalDeltaVsize;
        double maxDeltaVsize;
        edm::EventID eventMaxDeltaV;
        double totalEarlyVsize;
        double maxEarlyVsize;
        SignificantModule()
            : postEarlyCount(0),
              totalDeltaVsize(0),
              maxDeltaVsize(0),
              eventMaxDeltaV(),
              totalEarlyVsize(0),
              maxEarlyVsize(0) {}
        void set(double deltaV, bool early);
      };  // SignificantModule
      friend struct SignificantModule;
      friend std::ostream& operator<<(std::ostream& os, SimpleMemoryCheck::SignificantModule const& se);
      bool moduleSummaryRequested_;
      typedef std::map<std::string, SignificantModule> SignificantModulesMap;
      SignificantModulesMap modules_;
      double moduleEntryVsize_;
      void updateModuleMemoryStats(SignificantModule& m, double dv, edm::EventID const&);

      //Used to guarantee we only do one measurement at a time
      std::atomic<bool> measurementUnderway_;
      std::atomic<bool> moduleMeasurementUnderway_;
      std::atomic<unsigned int> moduleStreamID_;
      std::atomic<unsigned int> moduleID_;

    };  // SimpleMemoryCheck

    std::ostream& operator<<(std::ostream& os, SimpleMemoryCheck::SignificantEvent const& se);

    std::ostream& operator<<(std::ostream& os, SimpleMemoryCheck::SignificantModule const& se);

  }  // namespace service
}  // namespace edm

#ifdef __linux__
#define LINUX 1
#endif

#include <fcntl.h>
#include <unistd.h>

namespace edm {
  namespace service {

    static std::string d2str(double d) {
      std::ostringstream t;
      t << d;
      return t.str();
    }

    static std::string i2str(int i) {
      std::ostringstream t;
      t << i;
      return t.str();
    }

    ProcInfo SimpleMemoryCheck::fetch() { return piFetcher_.fetch(); }

    smapsInfo SimpleMemoryCheck::fetchSmaps() {
      smapsInfo ret;
      ret.private_ = 0;
      ret.pss_ = 0;
#ifdef LINUX
      fseek(smapsFile_, 0, SEEK_SET);
      ssize_t read;

      /*
       The format of the report is
       Private_Clean:        0 kB
       Private_Dirty:       72 kB
       Swap:                 0 kB
       Pss:                 72 kB
       */

      while ((read = getline(&smapsLineBuffer(), &smapsLineBufferLen_, smapsFile_)) != -1) {
        if (read > 14) {
          //Private
          if (0 == strncmp("Private_", smapsLineBuffer_, 8)) {
            unsigned int value = atoi(smapsLineBuffer_ + 14);
            //Convert from kB to MB
            ret.private_ += static_cast<double>(value) / 1024.;
          } else if (0 == strncmp("Pss:", smapsLineBuffer_, 4)) {
            unsigned int value = atoi(smapsLineBuffer_ + 4);
            //Convert from kB to MB
            ret.pss_ += static_cast<double>(value) / 1024.;
          }
        }
      }
#endif
      return ret;
    }

    double SimpleMemoryCheck::averageGrowthRate(double current, double past, int count) {
      return (current - past) / (double)count;
    }

    SimpleMemoryCheck::SimpleMemoryCheck(ParameterSet const& iPS, ActivityRegistry& iReg)
        : a_(),
          b_(),
          current_(&a_),
          previous_(&b_),
          pg_size_(sysconf(_SC_PAGESIZE))  // getpagesize()
          ,
          num_to_skip_(iPS.getUntrackedParameter<int>("ignoreTotal")),
          showMallocInfo_(iPS.getUntrackedParameter<bool>("showMallocInfo")),
          oncePerEventMode_(iPS.getUntrackedParameter<bool>("oncePerEventMode")),
          jobReportOutputOnly_(iPS.getUntrackedParameter<bool>("jobReportOutputOnly")),
          monitorPssAndPrivate_(iPS.getUntrackedParameter<bool>("monitorPssAndPrivate")),
          count_(),
          smapsFile_(nullptr),
          smapsLineBuffer_(nullptr),
          smapsLineBufferLen_(0),
          growthRateVsize_(),
          growthRateRss_(),
          moduleSummaryRequested_(iPS.getUntrackedParameter<bool>("moduleMemorySummary")),
          measurementUnderway_(false) {
      // changelog 2
      // pg_size = (double)getpagesize();
      std::ostringstream ost;

      openFiles();

      if (!oncePerEventMode_) {  // default, prints on increases
        iReg.watchPreSourceConstruction(this, &SimpleMemoryCheck::preSourceConstruction);
        iReg.watchPostSourceConstruction(this, &SimpleMemoryCheck::postSourceConstruction);
        iReg.watchPostSourceEvent(this, &SimpleMemoryCheck::postSourceEvent);
        iReg.watchPostModuleConstruction(this, &SimpleMemoryCheck::postModuleConstruction);
        iReg.watchPostModuleBeginJob(this, &SimpleMemoryCheck::postModuleBeginJob);
        iReg.watchPostEvent(this, &SimpleMemoryCheck::postEvent);
        iReg.watchPostModuleEvent(this, &SimpleMemoryCheck::postModule);
        iReg.watchPostBeginJob(this, &SimpleMemoryCheck::postBeginJob);
        iReg.watchPostEndJob(this, &SimpleMemoryCheck::postEndJob);
      } else {
        iReg.watchPostEvent(this, &SimpleMemoryCheck::postEvent);
        iReg.watchPostEndJob(this, &SimpleMemoryCheck::postEndJob);
      }
      if (moduleSummaryRequested_) {  // changelog 2
        iReg.watchPreModuleEvent(this, &SimpleMemoryCheck::preModule);
        if (oncePerEventMode_) {
          iReg.watchPostModuleEvent(this, &SimpleMemoryCheck::postModule);
        }
      }

      // The following are not currenty used/implemented below for either
      // of the print modes (but are left here for reference)
      //  iReg.watchPostBeginJob(this,
      //       &SimpleMemoryCheck::postBeginJob);
      //  iReg.watchPreProcessEvent(this,
      //       &SimpleMemoryCheck::preEventProcessing);
      //  iReg.watchPreModule(this,
      //       &SimpleMemoryCheck::preModule);

#ifndef __SANITIZE_ADDRESS__
      typedef MallocOpts::opt_type opt_type;
      MallocOptionSetter& mopts = getGlobalOptionSetter();

      opt_type p_mmap_max = iPS.getUntrackedParameter<int>("M_MMAP_MAX"),
               p_trim_thr = iPS.getUntrackedParameter<int>("M_TRIM_THRESHOLD"),
               p_top_pad = iPS.getUntrackedParameter<int>("M_TOP_PAD"),
               p_mmap_thr = iPS.getUntrackedParameter<int>("M_MMAP_THRESHOLD");

      if (p_mmap_max >= 0)
        mopts.set_mmap_max(p_mmap_max);
      if (p_trim_thr >= 0)
        mopts.set_trim_thr(p_trim_thr);
      if (p_top_pad >= 0)
        mopts.set_top_pad(p_top_pad);
      if (p_mmap_thr >= 0)
        mopts.set_mmap_thr(p_mmap_thr);

      mopts.adjustMallocParams();

      if (mopts.hasErrors()) {
        LogWarning("MemoryCheck") << "ERROR: Problem with setting malloc options\n" << mopts.error_message();
      }

      if (iPS.getUntrackedParameter<bool>("dump") == true) {
        MallocOpts mo = mopts.get();
        LogWarning("MemoryCheck") << "Malloc options: " << mo << "\n";
      }
#endif
    }

    SimpleMemoryCheck::~SimpleMemoryCheck() {
#ifdef LINUX
      if (nullptr != smapsFile_) {
        fclose(smapsFile_);
      }
#endif
      if (smapsLineBuffer_) {
        //getline will create the memory using malloc
        free(smapsLineBuffer_);
      }
    }

    void SimpleMemoryCheck::fillDescriptions(ConfigurationDescriptions& descriptions) {
      ParameterSetDescription desc;
      desc.addUntracked<int>("ignoreTotal", 1);
      desc.addUntracked<bool>("showMallocInfo", false);
      desc.addUntracked<bool>("oncePerEventMode", false);
      desc.addUntracked<bool>("jobReportOutputOnly", false);
      desc.addUntracked<bool>("monitorPssAndPrivate", false);
      desc.addUntracked<bool>("moduleMemorySummary", false);
      desc.addUntracked<int>("M_MMAP_MAX", -1);
      desc.addUntracked<int>("M_TRIM_THRESHOLD", -1);
      desc.addUntracked<int>("M_TOP_PAD", -1);
      desc.addUntracked<int>("M_MMAP_THRESHOLD", -1);
      desc.addUntracked<bool>("dump", false);
      descriptions.add("SimpleMemoryCheck", desc);
    }

    void SimpleMemoryCheck::openFiles() {
#ifdef LINUX
      if (monitorPssAndPrivate_) {
        std::ostringstream smapsNameOst;
        smapsNameOst << "/proc/" << getpid() << "/smaps";
        if ((smapsFile_ = fopen(smapsNameOst.str().c_str(), "r")) == nullptr) {
          throw Exception(errors::Configuration) << "Failed to open smaps file " << smapsNameOst.str() << std::endl;
        }
      }
#endif
    }

    void SimpleMemoryCheck::postBeginJob() {
      growthRateVsize_ = current_->vsize;
      growthRateRss_ = current_->rss;
    }

    void SimpleMemoryCheck::preSourceConstruction(ModuleDescription const& md) {
      bool expected = false;
      if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        updateAndPrint("pre-ctor", md.moduleLabel(), md.moduleName());
      }
    }

    void SimpleMemoryCheck::postSourceConstruction(ModuleDescription const& md) {
      bool expected = false;
      if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        updateAndPrint("ctor", md.moduleLabel(), md.moduleName());
      }
    }

    void SimpleMemoryCheck::postSourceEvent(StreamID sid) {
      bool expected = false;
      if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        updateAndPrint("module", "source", "source");
      }
    }

    void SimpleMemoryCheck::postModuleConstruction(ModuleDescription const& md) {
      bool expected = false;
      if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        updateAndPrint("ctor", md.moduleLabel(), md.moduleName());
      }
    }

    void SimpleMemoryCheck::postModuleBeginJob(ModuleDescription const& md) {
      bool expected = false;
      if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        updateAndPrint("beginJob", md.moduleLabel(), md.moduleName());
      }
    }

    void SimpleMemoryCheck::postEndJob() {
      if (not jobReportOutputOnly_) {
        LogAbsolute("MemoryReport")  // changelog 1
            << "MemoryReport> Peak virtual size " << eventT1_.vsize << " Mbytes"
            << "\n"
            << " Key events increasing vsize: \n"
            << eventL2_ << "\n"
            << eventL1_ << "\n"
            << eventM_ << "\n"
            << eventR1_ << "\n"
            << eventR2_ << "\n"
            << eventT3_ << "\n"
            << eventT2_ << "\n"
            << eventT1_;
      }
      if (moduleSummaryRequested_ and not jobReportOutputOnly_) {  // changelog 1
        LogAbsolute mmr("ModuleMemoryReport");                     // at end of if block, mmr
                                                                   // is destructed, causing
                                                                   // message to be logged
        mmr << "ModuleMemoryReport> Each line has module label and: \n";
        mmr << "  (after early ignored events) \n";
        mmr << "    count of times module executed; average increase in vsize \n";
        mmr << "    maximum increase in vsize; event on which maximum occurred \n";
        mmr << "  (during early ignored events) \n";
        mmr << "    total and maximum vsize increases \n \n";
        for (SignificantModulesMap::iterator im = modules_.begin(); im != modules_.end(); ++im) {
          SignificantModule const& m = im->second;
          if (m.totalDeltaVsize == 0 && m.totalEarlyVsize == 0)
            continue;
          mmr << im->first << ": ";
          mmr << "n = " << m.postEarlyCount;
          if (m.postEarlyCount > 0) {
            mmr << " avg = " << m.totalDeltaVsize / m.postEarlyCount;
          }
          mmr << " max = " << m.maxDeltaVsize << " " << m.eventMaxDeltaV;
          if (m.totalEarlyVsize > 0) {
            mmr << " early total: " << m.totalEarlyVsize;
            mmr << " max: " << m.maxEarlyVsize;
          }
          mmr << "\n";
        }
      }  // end of if; mmr goes out of scope; log message is queued

      Service<JobReport> reportSvc;
      // changelog 1
#define SIMPLE_MEMORY_CHECK_ORIGINAL_XML_OUTPUT
#ifdef SIMPLE_MEMORY_CHECK_ORIGINAL_XML_OUTPUT
      //     std::map<std::string, double> reportData;
      std::map<std::string, std::string> reportData;

      if (eventL2_.vsize > 0)
        eventStatOutput("LargeVsizeIncreaseEventL2", eventL2_, reportData);
      if (eventL1_.vsize > 0)
        eventStatOutput("LargeVsizeIncreaseEventL1", eventL1_, reportData);
      if (eventM_.vsize > 0)
        eventStatOutput("LargestVsizeIncreaseEvent", eventM_, reportData);
      if (eventR1_.vsize > 0)
        eventStatOutput("LargeVsizeIncreaseEventR1", eventR1_, reportData);
      if (eventR2_.vsize > 0)
        eventStatOutput("LargeVsizeIncreaseEventR2", eventR2_, reportData);
      if (eventT3_.vsize > 0)
        eventStatOutput("ThirdLargestVsizeEventT3", eventT3_, reportData);
      if (eventT2_.vsize > 0)
        eventStatOutput("SecondLargestVsizeEventT2", eventT2_, reportData);
      if (eventT1_.vsize > 0)
        eventStatOutput("LargestVsizeEventT1", eventT1_, reportData);

      if (eventRssT3_.rss > 0)
        eventStatOutput("ThirdLargestRssEvent", eventRssT3_, reportData);
      if (eventRssT2_.rss > 0)
        eventStatOutput("SecondLargestRssEvent", eventRssT2_, reportData);
      if (eventRssT1_.rss > 0)
        eventStatOutput("LargestRssEvent", eventRssT1_, reportData);
      if (eventDeltaRssT3_.deltaRss > 0)
        eventStatOutput("ThirdLargestIncreaseRssEvent", eventDeltaRssT3_, reportData);
      if (eventDeltaRssT2_.deltaRss > 0)
        eventStatOutput("SecondLargestIncreaseRssEvent", eventDeltaRssT2_, reportData);
      if (eventDeltaRssT1_.deltaRss > 0)
        eventStatOutput("LargestIncreaseRssEvent", eventDeltaRssT1_, reportData);

#ifdef __linux__
      struct mallinfo minfo = mallinfo();
      reportData.insert(std::make_pair("HEAP_ARENA_SIZE_BYTES", i2str(minfo.arena)));
      reportData.insert(std::make_pair("HEAP_ARENA_N_UNUSED_CHUNKS", i2str(minfo.ordblks)));
      reportData.insert(std::make_pair("HEAP_TOP_FREE_BYTES", i2str(minfo.keepcost)));
      reportData.insert(std::make_pair("HEAP_MAPPED_SIZE_BYTES", i2str(minfo.hblkhd)));
      reportData.insert(std::make_pair("HEAP_MAPPED_N_CHUNKS", i2str(minfo.hblks)));
      reportData.insert(std::make_pair("HEAP_USED_BYTES", i2str(minfo.uordblks)));
      reportData.insert(std::make_pair("HEAP_UNUSED_BYTES", i2str(minfo.fordblks)));
#endif

      // Report Growth rates for VSize and Rss
      reportData.insert(std::make_pair("AverageGrowthRateVsize",
                                       d2str(averageGrowthRate(current_->vsize, growthRateVsize_, count_))));
      reportData.insert(std::make_pair("PeakValueVsize", d2str(eventT1_.vsize)));
      reportData.insert(
          std::make_pair("AverageGrowthRateRss", d2str(averageGrowthRate(current_->rss, growthRateRss_, count_))));
      reportData.insert(std::make_pair("PeakValueRss", d2str(eventRssT1_.rss)));

      if (moduleSummaryRequested_) {  // changelog 2
        for (SignificantModulesMap::iterator im = modules_.begin(); im != modules_.end(); ++im) {
          SignificantModule const& m = im->second;
          if (m.totalDeltaVsize == 0 && m.totalEarlyVsize == 0)
            continue;
          std::string label = im->first + ":";
          reportData.insert(std::make_pair(label + "PostEarlyCount", i2str(m.postEarlyCount)));
          if (m.postEarlyCount > 0) {
            reportData.insert(std::make_pair(label + "AverageDeltaVsize", d2str(m.totalDeltaVsize / m.postEarlyCount)));
          }
          reportData.insert(std::make_pair(label + "MaxDeltaVsize", d2str(m.maxDeltaVsize)));
          if (m.totalEarlyVsize > 0) {
            reportData.insert(std::make_pair(label + "TotalEarlyVsize", d2str(m.totalEarlyVsize)));
            reportData.insert(std::make_pair(label + "MaxEarlyDeltaVsize", d2str(m.maxEarlyVsize)));
          }
        }
      }

      std::map<std::string, std::string> reportMemoryProperties;

      if (FILE* fmeminfo = fopen("/proc/meminfo", "r")) {
        char buf[128];
        char space[] = " ";
        size_t value;
        while (fgets(buf, sizeof(buf), fmeminfo)) {
          char* saveptr;
          char* token = nullptr;
          token = strtok_r(buf, space, &saveptr);
          if (token != nullptr) {
            value = atol(strtok_r(nullptr, space, &saveptr));
            std::string category = token;
            reportMemoryProperties.insert(std::make_pair(category.substr(0, strlen(token) - 1), i2str(value)));
          }
        }

        fclose(fmeminfo);
      }

      //      reportSvc->reportMemoryInfo(reportData, reportMemoryProperties);
      reportSvc->reportPerformanceSummary("ApplicationMemory", reportData);
      reportSvc->reportPerformanceSummary("SystemMemory", reportMemoryProperties);
#endif

#ifdef SIMPLE_MEMORY_CHECK_DIFFERENT_XML_OUTPUT
      std::vector<std::string> reportData;

      if (eventL2_.vsize > 0)
        reportData.push_back(eventStatOutput("LargeVsizeIncreaseEventL2", eventL2_));
      if (eventL1_.vsize > 0)
        reportData.push_back(eventStatOutput("LargeVsizeIncreaseEventL1", eventL1_));
      if (eventM_.vsize > 0)
        reportData.push_back(eventStatOutput("LargestVsizeIncreaseEvent", eventM_));
      if (eventR1_.vsize > 0)
        reportData.push_back(eventStatOutput("LargeVsizeIncreaseEventR1", eventR1_));
      if (eventR2_.vsize > 0)
        reportData.push_back(eventStatOutput("LargeVsizeIncreaseEventR2", eventR2_));
      if (eventT3_.vsize > 0)
        reportData.push_back(eventStatOutput("ThirdLargestVsizeEventT3", eventT3_));
      if (eventT2_.vsize > 0)
        reportData.push_back(eventStatOutput("SecondLargestVsizeEventT2", eventT2_));
      if (eventT1_.vsize > 0)
        reportData.push_back(eventStatOutput("LargestVsizeEventT1", eventT1_));

      if (eventRssT3_.rss > 0)
        eventStatOutput("ThirdLargestRssEvent", eventRssT3_, reportData);
      if (eventRssT2_.rss > 0)
        eventStatOutput("SecondLargestRssEvent", eventRssT2_, reportData);
      if (eventRssT1_.rss > 0)
        eventStatOutput("LargestRssEvent", eventRssT1_, reportData);
      if (eventDeltaRssT3_.deltaRss > 0)
        eventStatOutput("ThirdLargestIncreaseRssEvent", eventDeltaRssT3_, reportData);
      if (eventDeltaRssT2_.deltaRss > 0)
        eventStatOutput("SecondLargestIncreaseRssEvent", eventDeltaRssT2_, reportData);
      if (eventDeltaRssT1_.deltaRss > 0)
        eventStatOutput("LargestIncreaseRssEvent", eventDeltaRssT1_, reportData);

      struct mallinfo minfo = mallinfo();
      reportData.push_back(mallOutput("HEAP_ARENA_SIZE_BYTES", minfo.arena));
      reportData.push_back(mallOutput("HEAP_ARENA_N_UNUSED_CHUNKS", minfo.ordblks));
      reportData.push_back(mallOutput("HEAP_TOP_FREE_BYTES", minfo.keepcost));
      reportData.push_back(mallOutput("HEAP_MAPPED_SIZE_BYTES", minfo.hblkhd));
      reportData.push_back(mallOutput("HEAP_MAPPED_N_CHUNKS", minfo.hblks));
      reportData.push_back(mallOutput("HEAP_USED_BYTES", minfo.uordblks));
      reportData.push_back(mallOutput("HEAP_UNUSED_BYTES", minfo.fordblks));

      // Report Growth rates for VSize and Rss
      reportData.insert(std::make_pair("AverageGrowthRateVsize",
                                       d2str(averageGrowthRate(current_->vsize, growthRateVsize_, count_))));
      reportData.insert(std::make_pair("PeakValueVsize", d2str(eventT1_.vsize)));
      reportData.insert(
          std::make_pair("AverageGrowthRateRss", d2str(averageGrowthRate(current_->rss, growthRateRss_, count_))));
      reportData.insert(std::make_pair("PeakValueRss", d2str(eventRssT1_.rss)));

      reportSvc->reportMemoryInfo(reportData);
      // This is a form of reportMemoryInfo taking s vector, not a map
#endif
    }  // postEndJob

    void SimpleMemoryCheck::postEvent(StreamContext const& iContext) {
      ++count_;
      bool expected = false;
      if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        update();
        if (monitorPssAndPrivate_) {
          currentSmaps_ = fetchSmaps();
        }
        updateEventStats(iContext.eventID());
        if (oncePerEventMode_) {
          // should probably use be Run:Event or count_ for the label and name
          updateMax();
          andPrint("event", "", "");
        }
      }
    }

    void SimpleMemoryCheck::preModule(StreamContext const& iStreamContext, ModuleCallingContext const& iModuleContext) {
      bool expectedMeasurementUnderway = false;
      if (measurementUnderway_.compare_exchange_strong(expectedMeasurementUnderway, true, std::memory_order_acq_rel)) {
        std::shared_ptr<void> guard(
            nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
        bool expectedModuleMeasurementUnderway = false;
        if (moduleMeasurementUnderway_.compare_exchange_strong(expectedModuleMeasurementUnderway, true)) {
          update();
          // changelog 2
          moduleEntryVsize_ = current_->vsize;
          moduleStreamID_.store(iStreamContext.streamID().value(), std::memory_order_release);
          moduleID_.store(iModuleContext.moduleDescription()->id(), std::memory_order_release);
        }
      }
    }

    void SimpleMemoryCheck::postModule(StreamContext const& iStreamContext,
                                       ModuleCallingContext const& iModuleContext) {
      if (!oncePerEventMode_) {
        bool expected = false;
        if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
          std::shared_ptr<void> guard(
              nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
          auto const md = iModuleContext.moduleDescription();
          updateAndPrint("module", md->moduleLabel(), md->moduleName());
        }
      }

      if (moduleSummaryRequested_) {
        //is this the module instance we are measuring?
        if (moduleMeasurementUnderway_.load(std::memory_order_acquire) and
            (iStreamContext.streamID().value() == moduleStreamID_.load(std::memory_order_acquire)) and
            (iModuleContext.moduleDescription()->id() == moduleID_.load(std::memory_order_acquire))) {
          //Need to release our module measurement lock
          std::shared_ptr<void> guardModuleMeasurementUnderway(
              nullptr, [this](void const*) { moduleMeasurementUnderway_.store(false, std::memory_order_release); });
          bool expected = false;
          if (measurementUnderway_.compare_exchange_strong(expected, true, std::memory_order_acq_rel)) {
            std::shared_ptr<void> guardMeasurementUnderway(
                nullptr, [this](void const*) { measurementUnderway_.store(false, std::memory_order_release); });
            if (oncePerEventMode_) {
              update();
            }
            // changelog 2
            double dv = current_->vsize - moduleEntryVsize_;
            std::string label = iModuleContext.moduleDescription()->moduleLabel();
            updateModuleMemoryStats(modules_[label], dv, iStreamContext.eventID());
          }
        }
      }
    }

    void SimpleMemoryCheck::update() {
      std::swap(current_, previous_);
      *current_ = fetch();
    }

    void SimpleMemoryCheck::updateMax() {
      if ((*current_ > max_) || oncePerEventMode_) {
        if (count_ >= num_to_skip_) {
        }
        max_ = *current_;
      }
    }

    void SimpleMemoryCheck::updateEventStats(EventID const& e) {
      if (count_ < num_to_skip_)
        return;
      if (count_ == num_to_skip_) {
        eventT1_.set(0, 0, e, this);
        eventM_.set(0, 0, e, this);
        eventRssT1_.set(0, 0, e, this);
        eventDeltaRssT1_.set(0, 0, e, this);
        return;
      }
      double vsize = current_->vsize;
      double deltaVsize = vsize - eventT1_.vsize;

      // Update significative events for Vsize
      if (vsize > eventT1_.vsize) {
        double deltaRss = current_->rss - eventT1_.rss;
        eventT3_ = eventT2_;
        eventT2_ = eventT1_;
        eventT1_.set(deltaVsize, deltaRss, e, this);
      } else if (vsize > eventT2_.vsize) {
        double deltaRss = current_->rss - eventT1_.rss;
        eventT3_ = eventT2_;
        eventT2_.set(deltaVsize, deltaRss, e, this);
      } else if (vsize > eventT3_.vsize) {
        double deltaRss = current_->rss - eventT1_.rss;
        eventT3_.set(deltaVsize, deltaRss, e, this);
      }

      if (deltaVsize > eventM_.deltaVsize) {
        double deltaRss = current_->rss - eventM_.rss;
        if (eventL1_.deltaVsize >= eventR1_.deltaVsize) {
          eventL2_ = eventL1_;
        } else {
          eventL2_ = eventR1_;
        }
        eventL1_ = eventM_;
        eventM_.set(deltaVsize, deltaRss, e, this);
        eventR1_ = SignificantEvent();
        eventR2_ = SignificantEvent();
      } else if (deltaVsize > eventR1_.deltaVsize) {
        double deltaRss = current_->rss - eventM_.rss;
        eventR2_ = eventR1_;
        eventR1_.set(deltaVsize, deltaRss, e, this);
      } else if (deltaVsize > eventR2_.deltaVsize) {
        double deltaRss = current_->rss - eventR1_.rss;
        eventR2_.set(deltaVsize, deltaRss, e, this);
      }

      // Update significative events for Rss
      double rss = current_->rss;
      double deltaRss = rss - eventRssT1_.rss;

      if (rss > eventRssT1_.rss) {
        eventRssT3_ = eventRssT2_;
        eventRssT2_ = eventRssT1_;
        eventRssT1_.set(deltaVsize, deltaRss, e, this);
      } else if (rss > eventRssT2_.rss) {
        eventRssT3_ = eventRssT2_;
        eventRssT2_.set(deltaVsize, deltaRss, e, this);
      } else if (rss > eventRssT3_.rss) {
        eventRssT3_.set(deltaVsize, deltaRss, e, this);
      }
      if (deltaRss > eventDeltaRssT1_.deltaRss) {
        eventDeltaRssT3_ = eventDeltaRssT2_;
        eventDeltaRssT2_ = eventDeltaRssT1_;
        eventDeltaRssT1_.set(deltaVsize, deltaRss, e, this);
      } else if (deltaRss > eventDeltaRssT2_.deltaRss) {
        eventDeltaRssT3_ = eventDeltaRssT2_;
        eventDeltaRssT2_.set(deltaVsize, deltaRss, e, this);
      } else if (deltaRss > eventDeltaRssT3_.deltaRss) {
        eventDeltaRssT3_.set(deltaVsize, deltaRss, e, this);
      }
    }  // updateEventStats

    void SimpleMemoryCheck::andPrint(std::string const& type,
                                     std::string const& mdlabel,
                                     std::string const& mdname) const {
      if (not jobReportOutputOnly_ && ((*current_ > max_) || oncePerEventMode_)) {
        if (count_ >= num_to_skip_) {
          double deltaVSIZE = current_->vsize - max_.vsize;
          double deltaRSS = current_->rss - max_.rss;
          if (!showMallocInfo_) {  // default
            LogWarning("MemoryCheck") << "MemoryCheck: " << type << " " << mdname << ":" << mdlabel << " VSIZE "
                                      << current_->vsize << " " << deltaVSIZE << " RSS " << current_->rss << " "
                                      << deltaRSS;
          } else {
#ifdef __linux__
            struct mallinfo minfo = mallinfo();
#endif
            LogWarning("MemoryCheck") << "MemoryCheck: " << type << " " << mdname << ":" << mdlabel << " VSIZE "
                                      << current_->vsize << " " << deltaVSIZE << " RSS " << current_->rss << " "
                                      << deltaRSS
#ifdef __linux__
                                      << " HEAP-ARENA [ SIZE-BYTES " << minfo.arena << " N-UNUSED-CHUNKS "
                                      << minfo.ordblks << " TOP-FREE-BYTES " << minfo.keepcost << " ]"
                                      << " HEAP-MAPPED [ SIZE-BYTES " << minfo.hblkhd << " N-CHUNKS " << minfo.hblks
                                      << " ]"
                                      << " HEAP-USED-BYTES " << minfo.uordblks << " HEAP-UNUSED-BYTES "
                                      << minfo.fordblks
#endif
                ;
          }
        }
      }
    }

    void SimpleMemoryCheck::updateAndPrint(std::string const& type,
                                           std::string const& mdlabel,
                                           std::string const& mdname) {
      update();
      andPrint(type, mdlabel, mdname);
      updateMax();
    }

#ifdef SIMPLE_MEMORY_CHECK_ORIGINAL_XML_OUTPUT
    void SimpleMemoryCheck::eventStatOutput(std::string title,
                                            SignificantEvent const& e,
                                            std::map<std::string, std::string>& m) const {
      {
        std::ostringstream os;
        os << title << "-a-COUNT";
        m.insert(std::make_pair(os.str(), i2str(e.count)));
      }
      {
        std::ostringstream os;
        os << title << "-b-RUN";
        m.insert(std::make_pair(os.str(), d2str(static_cast<double>(e.event.run()))));
      }
      {
        std::ostringstream os;
        os << title << "-c-EVENT";
        m.insert(std::make_pair(os.str(), d2str(static_cast<double>(e.event.event()))));
      }
      {
        std::ostringstream os;
        os << title << "-d-VSIZE";
        m.insert(std::make_pair(os.str(), d2str(e.vsize)));
      }
      {
        std::ostringstream os;
        os << title << "-e-DELTV";
        m.insert(std::make_pair(os.str(), d2str(e.deltaVsize)));
      }
      {
        std::ostringstream os;
        os << title << "-f-RSS";
        m.insert(std::make_pair(os.str(), d2str(e.rss)));
      }
      if (monitorPssAndPrivate_) {
        {
          std::ostringstream os;
          os << title << "-g-PRIVATE";
          m.insert(std::make_pair(os.str(), d2str(e.privateSize)));
        }
        {
          std::ostringstream os;
          os << title << "-h-PSS";
          m.insert(std::make_pair(os.str(), d2str(e.pss)));
        }
      }
    }  // eventStatOutput
#endif

#ifdef SIMPLE_MEMORY_CHECK_DIFFERENT_XML_OUTPUT
    std::string SimpleMemoryCheck::eventStatOutput(std::string title, SignificantEvent const& e) const {
      std::ostringstream os;
      os << "  <" << title << ">\n";
      os << "    " << e.count << ": " << e.event;
      os << " vsize " << e.vsize - e.deltaVsize << " + " << e.deltaVsize << " = " << e.vsize;
      os << "  rss: " << e.rss << "\n";
      os << "  </" << title << ">\n";
      return os.str();
    }  // eventStatOutput

    std::string SimpleMemoryCheck::mallOutput(std::string title, size_t const& n) const {
      std::ostringstream os;
      os << "  <" << title << ">\n";
      os << "    " << n << "\n";
      os << "  </" << title << ">\n";
      return os.str();
    }
#endif
    // changelog 2
    void SimpleMemoryCheck::updateModuleMemoryStats(SignificantModule& m,
                                                    double dv,
                                                    edm::EventID const& currentEventID) {
      if (count_ < num_to_skip_) {
        m.totalEarlyVsize += dv;
        if (dv > m.maxEarlyVsize)
          m.maxEarlyVsize = dv;
      } else {
        ++m.postEarlyCount;
        m.totalDeltaVsize += dv;
        if (dv > m.maxDeltaVsize) {
          m.maxDeltaVsize = dv;
          m.eventMaxDeltaV = currentEventID;
        }
      }
    }  //updateModuleMemoryStats

    std::ostream& operator<<(std::ostream& os, SimpleMemoryCheck::SignificantEvent const& se) {
      os << "[" << se.count << "] " << se.event << "  vsize = " << se.vsize << " deltaVsize = " << se.deltaVsize
         << " rss = " << se.rss << " delta = " << se.deltaRss;

      if (se.monitorPssAndPrivate) {
        os << " private = " << se.privateSize << " pss = " << se.pss;
      }
      return os;
    }

    std::ostream& operator<<(std::ostream& os, SimpleMemoryCheck::SignificantModule const& sm) {
      if (sm.postEarlyCount > 0) {
        os << "\nPost Early Events:  TotalDeltaVsize: " << sm.totalDeltaVsize
           << " (avg: " << sm.totalDeltaVsize / sm.postEarlyCount << "; max: " << sm.maxDeltaVsize << " during "
           << sm.eventMaxDeltaV << ")";
      }
      if (sm.totalEarlyVsize > 0) {
        os << "\n     Early Events:  TotalDeltaVsize: " << sm.totalEarlyVsize << " (max: " << sm.maxEarlyVsize << ")";
      }

      return os;
    }

  }  // end namespace service
}  // end namespace edm

#if defined(__linux__)
using edm::service::SimpleMemoryCheck;
DEFINE_FWK_SERVICE(SimpleMemoryCheck);
#endif